• Introducing WebPros Cloud - a fully managed infrastructure platform purpose-built to simplify the deployment of WebPros products !  WebPros Cloud enables you to easily deliver WebPros solutions — without the complexity of managing the infrastructure.
    Join the pilot program today!
  • Support for BIND DNS has been removed from Plesk for Windows due to security and maintenance risks.
    If a Plesk for Windows server is still using BIND, the upgrade to Plesk Obsidian 18.0.70 will be unavailable until the administrator switches the DNS server to Microsoft DNS.

Forwarded to devs GIT extension - JavaScript bug for the Italian Localization

C

Claudio Scatoli

Guest
TITLE:
GIT extension - JavaScript bug for the Italian Localization
PRODUCT, VERSION, OPERATING SYSTEM, ARCHITECTURE:
GIT extension
Plesk Onyx 17.0.17 Update #42
CentOS
PROBLEM DESCRIPTION:
Hi there guys!
There's a tiny bug in the Italian localization for the GIT extension.

On the page where the GIT repositories for a domain/subdomain are listed, when clicking on the "Remove" link to remove a repo, it doesn't work it because of a javascript bug. As a result, the Git repo can't be removed.

The error from the JS console is
Code:
SyntaxError: missing ) after argument list
but it's not really missing a parenthesis: the problem is that in the italian translation of the command there's an apostrophe (as italian grammar norms dictate), and it screws with the single quotation marks used to list the command arguments.

The command is
Code:
javascript:pleskExt.Git.actions.remove('1', 'Rimuovere l'archivio "git"?');

"Rimuovere l'archivio" <- there is the problem, i guess it's just a matter of escaping that char.

Edit: sorry, i messed up with the attachments and other forum tags...
Edit2: i can't use a forum, for ****'s sake...​
STEPS TO REPRODUCE:
On the page with the list of GIT repos for a domain/subdomain, click on the link to "Remove" a repo.
brokenlink.png
ACTUAL RESULT:
The JS error interrupts the function.
error.png
EXPECTED RESULT:
A dialog asking for confirmation to remove the repo and, if confirmed, actually remove it.​
ANY ADDITIONAL INFORMATION:
Just switching Plesk's localization/language to English bypasses the bug, I then switch back to Italian​
YOUR EXPECTATIONS FROM PLESK SERVICE TEAM:
Confirm bug
 
Last edited by a moderator:
Thank you for report.
Bug was reproduced and submitted as PPPM-7793.

Workaround: change interface language.
 
Back
Top